← Back to question bank
JS FunctionMidMedium#2026 · 35m

Harden groupBy with stable ordering

Build groupBy with stable ordering. The interviewer expects a small, reusable utility with clear behavior under repeated calls and invalid inputs.

Answer Strategy

For groupBy with stable ordering, start by stating the public contract before writing code: argument shape, return shape, mutation rules, error behavior, and whether work is synchronous, timed, cached, or cancellable.

A senior solution uses boring names for hidden state. If the function stores a timer, cache entry, listener, or in-flight promise, say who owns that state and how it is cleaned up.

After the baseline passes, harden the edge cases: empty input, repeated calls, invalid values, thrown callbacks, stable ordering, and memory lifetime. The reference below is written to be narrated line by line.

Reference Implementation: Stable groupBy

A useful groupBy preserves source order inside each group and lets the caller choose the grouping key.

function groupBy<T>(
  items: T[],
  keyOf: (item: T) => string
): Record<string, T[]> {
  return items.reduce<Record<string, T[]>>((groups, item) => {
    const key = keyOf(item);
    groups[key] ??= [];
    groups[key].push(item);
    return groups;
  }, {});
}

Runnable Playground

Edit the implementation and run the tests directly in the browser. For system design questions, the playground focuses on the core state/data logic that the UI would call.


function groupBy<T>(
  items: T[],
  keyOf: (item: T) => string
): Record<string, T[]> {
  return items.reduce<Record<string, T[]>>((groups, item) => {
    const key = keyOf(item);
    groups[key] ??= [];
    groups[key].push(item);
    return groups;
  }, {});
}
TypeScript · runnable

Testing Strategy

Convert the answer into observable behavior. In a mid-senior interview, say which behaviors are covered by unit tests, interaction tests, accessibility checks, and one browser smoke path.

Contract
Test the public signature and return value first, including whether the utility mutates input or stores closure state.
Edges
Add empty input, repeated calls, duplicate values, thrown callbacks, and cleanup or cancellation cases.
Timing
Use fake timers for timer utilities and controlled promises for async utilities so behavior is deterministic.
test('groupBy preserves input order inside each group', () => {
  const rows = [
    { id: 'a', team: 'core' },
    { id: 'b', team: 'growth' },
    { id: 'c', team: 'core' },
  ];

  expect(groupBy(rows, (row) => row.team)).toEqual({
    core: [rows[0], rows[2]],
    growth: [rows[1]],
  });
});

Interviewer Signal

Tests whether you can turn a familiar utility into a precise contract instead of coding only the happy path.

Constraints

  • Define the function signature before coding.
  • Do not rely on global mutable state unless it is part of the returned closure.
  • Explain time and space cost for the common path.

Model Answer Shape

  • Write the smallest public contract first.
  • Cover empty input, repeated calls, thrown errors, and cleanup behavior.
  • Keep implementation readable enough to narrate under interview pressure.

Tradeoffs

  • A compact implementation is attractive, but explicit state names are easier to debug live.
  • Supporting every possible input can distract from the core contract; state the scope before coding.

Edge Cases

  • No arguments or undefined callbacks.
  • Synchronous throw inside the wrapped function.
  • Repeated calls before the previous result settles.

Testing And Proof

  • Happy path with representative inputs.
  • Boundary input and repeated invocation.
  • Cleanup or cancellation if timers or promises are involved.

Follow-Ups

  • How would you expose cancellation?
  • How would the API change for React usage?